refactor(core): TimeProvider migration Phase 2 — VMs, Mvc, TokenService#708
Merged
cct08311github merged 1 commit intodotnet10from Mar 21, 2026
Merged
Conversation
…— VMs, Mvc, TokenService) Replace direct DateTime.Now/UtcNow calls with Wtm.TimeProvider or injected TimeProvider across 9 files: - Core VMs: BaseBatchVM, BaseImportVM, BasePagedListVM, BaseTemplateVM - Mvc: _FrameworkController, FrameworkFilter, _AnalysisController, FileExtension - Auth: TokenService (constructor-injected TimeProvider) Key decisions: - TokenService: inject TimeProvider via optional ctor param (defaults to System) - FrameworkFilter: null-safe fallback (ctrl.Wtm?.TimeProvider ?? DateTime.Now) - BaseTemplateVM: null-safe (Wtm?.TimeProvider ?? TimeProvider.System) since Template instance may not have Wtm assigned - Use .UtcDateTime (not .DateTime) for UTC contexts to preserve DateTimeKind.Utc - Skip: .cshtml cache-bust, TypeExtension random data, codegen templates, property initializers, static BuildCsv, JWT LifetimeValidator Closes #706 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTime.Now/UtcNowtoTimeProvideracross 9 files (Core VMs, Mvc controllers/filters, TokenService)TimeProviderwith optional param (backwards compatible)BaseTemplateVMandFrameworkFilterwhereWtmmay be nullKey insight discovered
DateTimeOffset.DateTimereturnsDateTimeKind.Unspecified, causing JWT library to misinterpret UTC times as local. Fixed by using.UtcDateTimefor all UTC contexts.Skipped (by design)
.cshtmlcache-bust (DateTime.Now.Ticks) — display onlyTypeExtensionrandom data generation — not business logic.txttemplates — generated code styleRefreshTokenEntity,ChangeLog) — no DI at constructionBuildCsv— display timestampLifetimeValidatorlambda — security validation should use system timeTest plan
dotnet build -c Release— 0 errorsCloses #706
🤖 Generated with Claude Code